catch PropelAuthRateLimit error on all requests#66
Merged
andrew-propelauth merged 2 commits intomainfrom Feb 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR
Bumps minor version to 0.22.0
Currently, if a customer's BE hits a PropelAuth rate limit, this library converts the response into
After this change, these responses will instead be converted to
Note
All
validate*_api_keymethods perform additional parsing on the error body in the case of a 429 to distinguish between rate limits set by customers to be enforced on end-users – ie the recently addedand rate limits set and imposed by PropelAuth – ie the new
Test
5 request / 10 secondsand a rate limit of10 requests / 1 minuteon personal api keys.